Re: [trans-mem] tm_safe diagnostics

[Richard Henderson <rth at redhat dot com>]

On 07/10/2009 12:56 AM, Richard Guenther wrote:
> On Thu, Jul 9, 2009 at 10:14 PM, Richard Henderson<rth@redhat.com>  wrote:
> > The idea of tm_safe is to mark/verify functions and regions that perform no
> > action that cannot be undone by the transaction machinery, and thus will not
> > result in program termination should the transaction be aborted.
> >
> > Easily done once we've gimplified the function.
>
> With gimplification done unit-at-a-time (I'd appreciate a review of that
> patch) this has to be a separate pass run after gimplification (well, or
> merge with one of the two existing passes).  With all its pros and cons.
> So, if it is easy to do while still in GENERIC that is IMHO the prefered
> way.

Why would that be true that it has to be done as a separate pass?

Anyway, there's already two other warning passes that run on gimplified 
code, so it's not like I'm adding anything new here.  At present these 
warning passes are done just before handing off the function to cgraph.


r~