Re: Simple struct member offset doesn't need a full dwarf location expression

[Richard Henderson <rth at redhat dot com>]

On 07/08/2009 05:41 AM, Mark Wielaard wrote:
> This is slightly harder to test though, since neither gdb, nor systemtap
> currently support dwarf3 fully, in particular they don't support
> DW_OP_call_frame_cfa that is emitted with dwarf_version>  2.

Indeed.  Though perhaps you can snag Tom's preliminary support for
DW_OP_c_f_cfa from the gdb list archives and try with that.

As for MIPS, I think I'd prefer we consider that applies only to
dwarf2 output.  So write as

  if (dwarf_version > 2)
    {
      add_AT_int (...);
      return;
    }
  else
    {
      enum dwarf_location_atom op;

#ifdef MIPS_DEBUGGING_INFO
      op = DW_OP_constu;
#else
      op = DW_OP_plus_uconst;
#endif

      loc_descr = new_loc_descr (op, offset, 0);
    }

Ok with that change.


r~