This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR37053: Move tweaks of commutative precedence to target hook


Hi folks,

I gave it a try with Maxim's patch from ticket #37053 and it degraded
performance pretty badly (> 30%), and galgel degraded more than 75%.
Both 32-bit and 64-bit saw degradations.

Worth noticing that the patch posted here didn't degrade performance (i
heard that's Paolo's idea):

http://gcc.gnu.org/ml/gcc-patches/2009-06/msg02038.html

Regards,
Luis

On Fri, 2009-06-26 at 11:40 -0500, Peter Bergner wrote:
> On Fri, 2009-06-26 at 20:33 +0400, Maxim Kuvyrkov wrote:
> > +static int
> > +rs6000_commutative_operand_precedence (const_rtx op, int value)
> > +{
> > +  /* Prefer pointer objects over non pointer objects.
> > +     For rationale see PR28690.  */
> > +  if (GET_RTX_CLASS (GET_CODE (op)) == RTX_OBJ
> > 
> > ... and the patch decrements the value only for RTX_OBJs.
> 
> I'm sorry, I completely missed that hunk.  In that case, it does look
> equivalent.  Luis' test runs will verify that.
> 
> Peter



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]