This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] PR40525: Try noce path in dead_or_predicable if the ce path fails

From: Richard Henderson <rth at redhat dot com>
To: Steven Bosscher <stevenb dot gcc at gmail dot com>
Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
Date: Thu, 25 Jun 2009 14:01:08 -0700
Subject: Re: [patch] PR40525: Try noce path in dead_or_predicable if the ce path fails
References: <571f6b510906251317i31bfc0a8jed9e1e2a50bb406a@mail.gmail.com>

       if (! cond_exec_process_insns ((ce_if_block_t *)0, head, end, cond,
-				     prob_val, 0))
-	goto cancel;
-
+				     prob_val, 0)
+	  || ! verify_changes (0))
+	cancel_changes (0);
+      n_validated_changes = num_validated_changes ();

I'd prefer to see this bit written without the nots; ie

  if (cond_exec_process_insns (NULL, head, end, cond, prob_val, 0)
      && verify_changes (0))
    n_validated_changes = num_validated_changes ();
  else
    cancel_changes (0);

Otherwise ok.

r~

References:
- [patch] PR40525: Try noce path in dead_or_predicable if the ce path fails
  - From: Steven Bosscher

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]