This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch][plugin,mudflap] Mark builtin alloca as not inlineable


Paolo Bonzini <bonzini@gnu.org> writes:

>>> ok, I looked into this patch and this is not about inlining functions
>>> containing alloca but rather always expanding of alloca inlined.
>>> So really using CALL_CANNOT_INLINE_P is wrong as really it we are
>>> trying to force expanding of alloca inlined in the function.
>>
>> Why is using CALL_CANNOT_INLINE_P wrong?  It looks exactly right to me:
>> when using -fmudflap, the call to alloca may not be inlined.
>
> Is this an approval?

No.  It's a comment and/or a question.

(For future reference, I generally don't approve patches from people at
Google unless I consider them to be obvious.  Though I'm sure there are
exceptions from time to time.)

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]