This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch ARM] Disable -mcaller-super-interworking and -mcallee-super-interworking for AAPCS.


On Fri, 2009-06-19 at 22:48 +0100, Ramana Radhakrishnan wrote:
> On 17 Jun 2009, at 00:06, Joseph S. Myers wrote:
> 
> > On Wed, 17 Jun 2009, Ramana Radhakrishnan wrote:
> >
> >> Hi,
> >>
> >> I don't think these options are valid on AAPCS configurations because
> >> AAPCS mandates interworking. Hence I propose to disable these options
> >> for AAPCS.
> >>
> >> Tested by building cross to arm-none-eabi . Ok to commit ?
> >
> > I think this code would get an "ambiguous else" warning and so fail to
> > bootstrap natively; you need to add braces around the contents of the
> > outer if.
> >
> > Use %' in place of ' (used as apostrophe rather than quote) in English
> > language diagnostics so that a proper apostrophe is used when LC_CTYPE
> > supports it.
> 
> Here's a patch that fixes these comments - I've gone with Paul's  
> suggestion
> to remove the '.
> 
> Ok to commit now ?

OK.

R.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]