This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH RFA: Add new warning for jump across initialized variable
On Fri, Jun 19, 2009 at 9:07 PM, H.J. Lu<hjl.tools@gmail.com> wrote:
> On Mon, Jun 15, 2009 at 10:13 PM, Ian Lance Taylor<iant@google.com> wrote:
>> "Joseph S. Myers" <joseph@codesourcery.com> writes:
>>
>>> On Wed, 10 Jun 2009, Ian Lance Taylor wrote:
>>>
>>>> This patch adds a new warning to the C frontend: -Wgoto-misses-init.
>>>> This warns about cases where a goto, or a switch, branches across the
>>>> initialization of a variable. ÂFor example:
>>>
>>> Since this covers switch statements, I think an option name only
>>> mentioning goto is bad; -Wjump-misses-init or -Wjump-across-init would be
>>> better. ÂOK with that change and otherwise fixed as indicated below.
>>
>> Thanks. ÂFixed, updated, rebootstrapped, retested, and committed. ÂI use
>> -Wjump-misses-init because in a case like
>>
>> Âgoto a:
>> Â{
>> Â Âint a = 0;
>> Â b:
>> Â}
>> Âa:
>> Âgoto b;
>>
>> the initialization is missed, but not crossed.
>>
>
> This breaks binutils build:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40500
And this is expected behavior as the warning is doing what it is
supposed to be doing.
-- Pinski