This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] prevent breakage of eh call/return@ assumption on hppa


Hello Richard,

Richard Henderson wrote:
> Instead of triggering this on call-frame information, trigger it on
> 
>    can_throw_internal(call_insn) || can_throw_external(call_insn)

 OK,
 
> Though I suppose we could introduce a cheaper predicate that tests both, 
> at present almost everything in the compiler only really cares about the 
> former test.

 And a cheaper predicate is not required here, as we're in a
 straight linear code sequence only reached in very rare situations so
 there's really no super-efficiency concern.

 Will commit the adjusted version when re-testing finishes.

 Thanks for your review :)

 Olivier


 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]