This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [plugin] Mudflap plugin


On Thu, Jun 18, 2009 at 3:12 AM, Rafael Espindola<espindola@google.com> wrote:
>> This is great work, as I said. ?I think the first steps should be to
>> separate the infrastructure changes and submit them separately.
>
> I agree!
>
> Having mudflap as a plugin would make sure it uses a cleaner interface
> to the rest of the compiler.
>
> Some items that I think can go in first
>
> * ) I see that you added a flag_no_builtin_alloca. If Paolo's
> suggestion of calling gimple_call_set_cannot_inline doesn't work, you
> can use this flag in expand_builtin_alloca instead of flag_plugin.
>

Agreed.

> * ) You moved the call to initialize_plugins to compile_file. We need
> to load plugins early so that things like "gcc --help -v" can display
> the plugins's help. Can you add a new callback instead of moving the
> call to initialize_plugins?
>

I understand. I 'll introduce a PLUGIN_START_UNIT callback, sounds symmetric to
PLUGIN_FINISH_UNIT.

Thanks for the reviews.

tunji


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]