This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH, middle-end]: Convert (int)logb() into ilogb().


On Thu, 18 Jun 2009, Uros Bizjak wrote:

> On Thu, Jun 18, 2009 at 12:41 PM, Richard Guenther<rguenther@suse.de> wrote:
> 
> >> Just an old middle-end patch I have found while cleaning my patch
> >> archive. While it uses old infrastructure for conversion, it actually
> >> converts in the same way as e.g. (long)round(d) -> lround(d) a couple
> >> of lines above.
> 
> > I think in addition of testing flag_unsafe_math_optimizations you
> > should test !flag_trapping_math and !flag_math_errno and
> > flag_finite_math_only (basically for -ffast-math which we do not
> > have a single flag for).
> >
> > Ok with that change.
> 
> Thanks, I have changed the patch according to your suggestion.
> However, I wonder if other fp->int conversions in convert_to_integer()
> (i.e. round->lround) also need additional flags tested?

Quite possibly.  As you noted this area of the compiler needs major
cleanup.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]