This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [plugin] Mudflap plugin



* ) I see that you added a flag_no_builtin_alloca. If Paolo's
suggestion of calling gimple_call_set_cannot_inline doesn't work, you
can use this flag in expand_builtin_alloca instead of flag_plugin.

I think that should actually go in with the plugin, since it would be unused otherwise.


* ) You moved the call to initialize_plugins to compile_file. We need
to load plugins early so that things like "gcc --help -v" can display
the plugins's help. Can you add a new callback instead of moving the
call to initialize_plugins?

* ) The move of PLUGIN_FINISH_UNIT looks correct to me. Paolo, why do
you need another callback?

I thought it was there for a reason. :-) Apparently my judgement was wrong for PLUGIN_FINISH_UNIT, and I should have thought the same about initialize_plugins instead.


Paolo


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]