This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix ICE with __builtin_unreachable() as only statement in a function.


On Wed, Jun 17, 2009 at 9:33 AM, Paolo Bonzini<paolo.bonzini@gmail.com> wrote:
> David Daney wrote:
>>
>> This patch fixed an ICE I found doing additional __builtin_unreachable()
>> ?testing.
>>
>> If __builtin_unreachable() is the only statement in a function, the
>> resulting barrier will be the first non-note insn when doing barrier
>> cleanup. ?This causes SIGSEGV in cleanup_barriers. ?The fix is to check for
>> NULL before dereferencing.
>
> I think the comment is overkill here. ?If somebody wonders what it's for,
> svn blame plus the testcase will be more than enough to point him in the
> right direction.

The patch is ok w/o the comment.

Thanks,
Richard.

> Paolo
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]