This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [named-addr-space] Cleanup target hooks

On Tue, Jun 16, 2009 at 07:50:50AM -0400, Paolo Bonzini wrote:
> This patch completes the transition to TARGET_LEGITIMATE_ADDRESS_P
> and TARGET_LEGITIMIZE_ADDRESS, which made the presence of separate
> hooks for non-generic address spaces superfluous.
> If this is accepted, I'll convert the other targets to add the
> new argument, which is a trivial patch.
> I also have a followup that eliminates memory_address_addr_space_p
> since it can be changed to a direct invocation of the target hook.
> Built cc1 for spu-elf.  Ok for named-addr-spaces branch?
> Thanks,

In general these patches are ok.  Obviously it is better to have just one hook
than two separate hooks.  Ben and I used the two hooks simply to avoid having
to change all of the other targets.  When I was giving the talk about the named
address space changes last week, I wondered whether it might be better to have
an abstraction for funny addresses, to handle things like reverse endian, etc.
But until somebody actually write the abstraction, I would say go with passing
an additional argument for the address space.

Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]