This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH: PR/40416] stop sinking expression if the target bb post dominates from bb

From: Eric Botcazou <ebotcazou at adacore dot com>
To: Richard Guenther <richard dot guenther at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org, Carrot Wei <carrot at google dot com>, Daniel Berlin <dannyb at google dot com>
Date: Tue, 16 Jun 2009 12:20:29 +0200
Subject: Re: [PATCH: PR/40416] stop sinking expression if the target bb post dominates from bb
References: <7587b290906160158p15cf5efdm422de1d05be77f4d@mail.gmail.com> <84fc9c000906160252h2a4fe079w390c3532aacd7d1b@mail.gmail.com>

> The patch itself is ok as soon as it no longer exposes that bug
> and with added comments before the dominator checks (similar
> to the existing check).

And with a correct ChangeLog entry (no "add code"...), see the existing ones.

-- 
Eric Botcazou

References:
- [PATCH: PR/40416] stop sinking expression if the target bb post dominates from bb
  - From: Carrot Wei
- Re: [PATCH: PR/40416] stop sinking expression if the target bb post dominates from bb
  - From: Richard Guenther

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]