This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix recent debug.exp failures
On Fri, Jun 12, 2009 at 08:12:23PM +0200, Jakub Jelinek wrote:
> On Fri, Jun 12, 2009 at 06:38:20PM +0200, Hans-Peter Nilsson wrote:
> > > Date: Tue, 09 Jun 2009 00:06:20 -0700
> > > From: Richard Henderson <rth@redhat.com>
> >
> > > There is one quirk. Previously we'd accept options like -gdwarf-23
> > > and take that to mean dwarf2 debugging, verbosity level 3. Now
> > > you *must* write this as -gdwarf-2 -g3.
> >
> > A -gdwarf-21 is currently not the same as -gdwarf-2 -g1, as a
> > regtest of e.g. r148404 (before your change) together with
> > <http://gcc.gnu.org/ml/gcc-patches/2009-06/msg00962.html> will
> > show. For example just C:
>
> That's because -gdwarf-2 -g1 as separate option no longer matches the
> "*1" check on the first argument.
> This patch works for me. Note that I'm not using -gstabs -g3 etc.,
> because unlike -gdwarf-2 where the separate option make no difference,
> -gstabs3 and -gstabs -g3 as I read opts.c might be different (the difference
> is in use_gnu_debug_info_extensions, -gstabs3 sets it to 0, while
> -gstabs -g3 sets it to DEFAULT_GDB_EXTENSIONS.
>
> 2009-06-12 Jakub Jelinek <jakub@redhat.com>
>
> PR testsuite/40426
> * lib/gcc-dg.exp (gcc-dg-debug-runtest): For type -gdwarf-2 and
> level != "" use separate -gdwarf-2 -g${level} options instead of
> -gdwarf-2${level}.
> * lib/gfortran-dg.exp (gfortran-dg-debug-runtest): Likewise.
> * gfortran.dg/debug/pr37738.f: Also skip if -gdwarf-2 -g1.
> * gfortran.dg/debug/pr35154-dwarf2.f: Likewise.
This patch is ok for the mainline (and supercedes the patch I came up with to
solve the same problem).
I do think it may be time to separate out the debug level from the debug
format, but that is another discussion.
--
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com