This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] First attempt at unwind epilogue support for powerpc{,64} (take 2)


Jakub Jelinek wrote:
On Tue, Jun 02, 2009 at 01:14:11PM -0700, Richard Henderson wrote:
This condition ought to be pulled out to a predicate function.
It's complex and used more than once.
...
Could use gen_add3_insn to tidy some of this up.
...
plus_constant.

Here is a patch with the above suggestions incorporated, bootstrapped on powerpc64-linux --with-cpu=default32, regtested with both -m32 and -m64. Ok for trunk?

2009-06-03 Jakub Jelinek <jakub@redhat.com>

This causes the build of newlib for powerpc-eabi to fail.


auto-host.h is included even when HAVE_GAS_CFI_DIRECTIVE
is not defined.

Here's a possible fix:

Index: ppc-asm.h
===================================================================
--- ppc-asm.h   (revision 148210)
+++ ppc-asm.h   (working copy)
@@ -196,10 +196,8 @@
        .size FUNC_NAME(name),GLUE(.L,name)-FUNC_NAME(name)
 #endif

-/* For HAVE_GAS_CFI_DIRECTIVE.  */
-#include "auto-host.h"
-
 #ifdef HAVE_GAS_CFI_DIRECTIVE
+#include "auto-host.h"
 # define CFI_STARTPROC                 .cfi_startproc
 # define CFI_ENDPROC                   .cfi_endproc
 # define CFI_OFFSET(reg, off)          .cfi_offset reg, off


-- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]