This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] Add discriminators to DWARF line table

From: Diego Novillo <dnovillo at google dot com>
To: tromey at redhat dot com
Cc: gcc-patches at gcc dot gnu dot org
Date: Wed, 3 Jun 2009 11:15:28 -0400
Subject: Re: [patch] Add discriminators to DWARF line table
References: <c17be2b30904211616t1e992d09uaa16cb053ed881b2@mail.gmail.com> <20090422041933.GA32221@caradoc.them.org> <c17be2b30904221100q20d8151eifd0489c69ae01a18@mail.gmail.com> <c17be2b30904221737n6c52a29er3b7bd423bca49af8@mail.gmail.com> <c17be2b30904291620g7bc1b4d2k78728c33320e07f4@mail.gmail.com> <b798aad50906021338g43cd9113idbcac0697eeb8a11@mail.gmail.com> <c17be2b30906021402t55eee977hadd039ec56986919@mail.gmail.com> <c17be2b30906021803o4e8ab989p330f7822a4e225a4@mail.gmail.com> <m3oct5qtqe.fsf@fleche.redhat.com>

On Wed, Jun 3, 2009 at 10:26, Tom Tromey <tromey@redhat.com> wrote:

> Cary> Â return strcmp (from.file, to.file);
>
> I think that should be: return !strcmp (...)

Good catch, but let's use strcmp(...) == 0, please.


Diego.

Follow-Ups:
- Re: [patch] Add discriminators to DWARF line table
  - From: Cary Coutant

References:
- Re: [patch] Add discriminators to DWARF line table
  - From: Diego Novillo
- Re: [patch] Add discriminators to DWARF line table
  - From: Cary Coutant
- Re: [patch] Add discriminators to DWARF line table
  - From: Cary Coutant
- Re: [patch] Add discriminators to DWARF line table
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]