This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [vta, trunk?] oops, one more: don't crash on ppc64's expr_lists in parallels


Alexandre Oliva <aoliva@redhat.com> writes:

> On Jun  1, 2009, Ian Lance Taylor <iant@google.com> wrote:
>
>> Alexandre Oliva <aoliva@redhat.com> writes:
>>>        if (GET_CODE (in_rtx) == EXPR_LIST
>>>            || GET_CODE (in_rtx) == INSN_LIST)
>>>          fprintf (outfile, ":%s",
>>> -		     GET_REG_NOTE_NAME (GET_MODE (in_rtx)));
>>> +		     (int)GET_MODE (in_rtx) >= REG_NOTE_MAX
>>> +		     ? GET_MODE_NAME (GET_MODE (in_rtx))
>>> +		     : GET_REG_NOTE_NAME (GET_MODE (in_rtx)));
>
>> Write this as
>
>>   if ((GET_CODE (in_rtx) == EXPR_LIST
>>        || GET_CODE (in_rtx) == INSN_LIST)
>>       && (int) GET_MODE (in_rtx) < (int) REG_NOTE_MAX)
>
>> (rather than duplicating GET_MODE_NAME).
>
> Just to be sure...  Are you suggesting we refrain from printing the mode
> of an EXPR_LIST and INSN_LIST when the mode is not in the REG_NOTE
> range?

No.  The else clause will print it.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]