This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix PR c++/38089: g++ crash on invalid code


Simon Martin wrote:

> The attached patch fixes this by setting the specialization's
> DECL_CONTEXT simply to the template's DECL_CONTEXT. The code has been
> like this since the beginning (i.e. when it was added, in 3.4.2, to fix
> PR 16224), but it looks wrong (in case there's some tricky case I don't
> see and it's correct, returning error_mark_node also fixes the PR...).

> :ADDPATCH c++:

:REVIEWMAIL: OK

It's possible that this will lead to some other odd crash somehow.  If
it does, the right response is probably going to be to completely
discard the specialization.  But, let's try your approach.

Thanks,

-- 
Mark Mitchell
CodeSourcery
mark@codesourcery.com
(650) 331-3385 x713


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]