This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [trunk<-vta] Re: [vta,vta4.3,trunk?] avoid accidental moving of death notes in combine


Alexandre Oliva <aoliva@redhat.com> writes:

>>From  Alexandre Oliva  <aoliva@redhat.com>
>
> 	* combine.c (move_deaths): Compare LUIDs within the same BB only.
>
> Index: gcc/combine.c
> ===================================================================
> --- gcc/combine.c.orig	2009-05-28 04:16:44.000000000 -0300
> +++ gcc/combine.c	2009-05-28 04:33:57.000000000 -0300
> @@ -12143,7 +12143,7 @@ move_deaths (rtx x, rtx maybe_kill_insn,
>  	  && ! reg_referenced_p (x, maybe_kill_insn))
>  	return;
>  
> -      if (where_dead
> +      if (where_dead && BLOCK_FOR_INSN (where_dead) == BLOCK_FOR_INSN (to_insn)
>  	  && DF_INSN_LUID (where_dead) >= from_luid
>  	  && DF_INSN_LUID (where_dead) < DF_INSN_LUID (to_insn))

Please format as

      if (where_dead
	  && BLOCK_FOR_INSN (where_dead) == BLOCK_FOR_INSN (to_insn)
	  && DF_INSN_LUID (where_dead) >= from_luid
 	  && DF_INSN_LUID (where_dead) < DF_INSN_LUID (to_insn))

In a chain of logical operators, I think it's best if they are all at
the same level.

OK with that change.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]