This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

[trunk<-vta] Re: [vta,vta4.3,trunk?] preserve label name in deleted names across GC


On Sep 10, 2008, Alexandre Oliva <aoliva@redhat.com> wrote:

> Here's another actual GCC bug that I noticed because of
> -fcompare-debug.  When we turn a label that had a LABEL_NAME into a
> NOTE_INSN_DELETED_LABEL, we preserve the LABEL_NAME in the note, but
> there's nothing in the GC machinery to prevent the label name from
> being collected.  If GC hits, dumps afterwards will print garbage.
> This patch arranges for the LABEL_NAME to be kept alive along with the
> NOTE_INSN_DELETED_LABEL.  Ok for trunk?

Ping?

for  gcc/ChangeLog
from  Alexandre Oliva  <aoliva@redhat.com>

	* gengtype.c (adjust_field_rtx_def): Add NOTE_INSN_DELETED_LABEL's
	label string.

Index: gcc/gengtype.c
===================================================================
--- gcc/gengtype.c.orig	2009-05-28 04:15:17.000000000 -0300
+++ gcc/gengtype.c	2009-05-28 04:34:06.000000000 -0300
@@ -1016,6 +1016,7 @@ adjust_field_rtx_def (type_p t, options_
 	switch (c)
 	  {
 	  case NOTE_INSN_MAX:
+	  case NOTE_INSN_DELETED_LABEL:
 	    note_flds = create_field (note_flds, &string_type, "rt_str");
 	    break;
 

-- 
Alexandre Oliva, freedom fighter    http://FSFLA.org/~lxoliva/
You must be the change you wish to see in the world. -- Gandhi
Be Free! -- http://FSFLA.org/   FSF Latin America board member
Free Software Evangelist      Red Hat Brazil Compiler Engineer

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]