This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch: enable -fshow-column by default


Aldy Hernandez <aldyh@redhat.com> writes:

> gcc/
> 	* diagnostic.c (diagnostic_build_prefix): Always print columns.
> 	(diagnostic_report_current_module): Print columns.
> 	* common.opt (flag_show_column): Enable by default.
> gcc/testsuite/
> 	* lib/gcc-dg.exp (dg-bogus): Override dg-bogus.
> 	(process-message): Expect column numbers.
> 	* gcc.dg/va-arg-2.c: Use line 0 to indicate no column.
> 	* gcc.dg/pch/counter-2.c: Same.
> 	* gcc.dg/pch/valid-2.c: Same.
> 	* gcc.dg/pch/warn-1.c: Same.
> 	* gcc.dg/pch/valid-1.c: Same.
> gcc/cp/
> 	* error.c (print_instantiation_partial_context): Print column
> 	numbers.
> 	* cpp/include2a.c: Handle lack of columns.
> 	* cpp/syshdr.c: Same.
> 	* cpp/19940712-1.c: Same.
> 	* cpp/missing-header-1.c: Same.
> 	* cpp/unc4.c: Remove -fno-show-column.
> 	* cpp/tr-warn3.c: Same.
> 	* cpp/pr29612-2.c: Same.
> 	* cpp/tr-warn4.c: Same.
> 	* cpp/Wtrigraphs.c: Same.
> 	* cpp/poison.c: Same.
> 	* cpp/arith-3.c: Same.
> 	* cpp/sysmac2.c: Same.
> 	* cpp/cpp.exp: Same.
> 	* cpp/tr-warn5.c: Same.
> 	* cpp/include2.c: Same.
> 	* cpp/Wmissingdirs.c: Same.
> 	* cpp/Wmissingdirs.c: Same.
> 	* cpp/tr-warn6.c: Same.
> 	* cpp/Wtrigraphs-2.c: Same.
> 	* cpp/macspace1.c: Same.
> 	* cpp/escape-2.c: Same.
> 	* cpp/assert2.c: Same.
> 	* cpp/undef2.c: Same.
> 	* cpp/macspace2.c: Same.
> 	* cpp/tr-warn1.c: Same.
> 	* cpp/extratokens2.c: Same.
> 	* cpp/strify2.c: Same.
> 	* cpp/Wsignprom.c: Same.
> 	* cpp/redef2.c: Same.
> 	* cpp/trad/trad.exp: Same.
> 	* cpp/arith-1.c: Same.
> 	* cpp/extratokens.c: Same.
> 	* cpp/if-mpar.c: Same.
> libcpp/
> 	* include/line-map.h (LAST_SOURCE_COLUMN): New.

ChangeLog entries should be for gcc.dg/cpp/XXX, not just cpp/XXX.

> -      pp_verbatim (context->printer, _("%s:%d:   instantiated from %qs\n"),
> -		   xloc.file, xloc.line,
> -		   decl_as_string_translate (t->decl,
> -					     TFF_DECL_SPECIFIERS | TFF_RETURN_TYPE));
> +      str = decl_as_string (t->decl, TFF_DECL_SPECIFIERS | TFF_RETURN_TYPE);

You need to set str to decl_as_string_translate (...).  Joseph changed
it recently.

OK with those changes.

Thanks for working on this.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]