Re: [PATCH 2/3] Remove SRA parameters.

[Richard Guenther <richard dot guenther at gmail dot com>]

On Tue, May 26, 2009 at 1:40 PM, Martin Jambor <mjambor@suse.cz> wrote:
> The new SRA no longer uses any parameters, this patch removes them
> from both the source code and documentation (except that
> sra-max-structure-count was not even there).
>
> Tested together with the SRA tests, I also did "make pdf" and checked
> that the affected place looks sane.
>
> OK, for trunk (after the new SRA gets in)?

Ok.

Thanks,
Richard.

> Thanks,
>
> Martin
>
>
> 2009-05-26 ?Martin Jambor ?<mjambor@suse.cz>
>
> ? ? ? ?* params.def (PARAM_SRA_MAX_STRUCTURE_SIZE): Removed.
> ? ? ? ?(PARAM_SRA_MAX_STRUCTURE_COUNT): Removed.
> ? ? ? ?(PARAM_SRA_FIELD_STRUCTURE_RATIO): Removed.
> ? ? ? ?* params.h (SRA_MAX_STRUCTURE_SIZE): Removed.
> ? ? ? ?(SRA_MAX_STRUCTURE_COUNT): Removed.
> ? ? ? ?(SRA_FIELD_STRUCTURE_RATIO): Removed.
> ? ? ? ?* doc/invoke.texi (sra-max-structure-size): Removed.
> ? ? ? ?(sra-field-structure-ratio): Removed.
>
>
> Index: mine/gcc/doc/invoke.texi
> ===================================================================
> --- mine.orig/gcc/doc/invoke.texi
> +++ mine/gcc/doc/invoke.texi
> @@ -7307,19 +7307,6 @@ In each case, the @var{value} is an inte
> ?@var{name} are given in the following table:
>
> ?@table @gcctabopt
> -@item sra-max-structure-size
> -The maximum structure size, in bytes, at which the scalar replacement
> -of aggregates (SRA) optimization will perform block copies. ?The
> -default value, 0, implies that GCC will select the most appropriate
> -size itself.
> -
> -@item sra-field-structure-ratio
> -The threshold ratio (as a percentage) between instantiated fields and
> -the complete structure size. ?We say that if the ratio of the number
> -of bytes in instantiated fields to the number of bytes in the complete
> -structure exceeds this parameter, then block copies are not used. ?The
> -default is 75.
> -
> ?@item struct-reorg-cold-struct-ratio
> ?The threshold ratio (as a percentage) between a structure frequency
> ?and the frequency of the hottest structure in the program. ?This parameter
> Index: mine/gcc/params.def
> ===================================================================
> --- mine.orig/gcc/params.def
> +++ mine/gcc/params.def
> @@ -38,36 +38,6 @@ along with GCC; see the file COPYING3.
>
> ? ?Be sure to add an entry to invoke.texi summarizing the parameter. ?*/
>
> -/* The maximum structure size at which the scalar replacement of
> - ? aggregates (SRA) pass will perform block copies. ?The default
> - ? value, 0, implies that GCC will select the most appropriate size
> - ? itself. ?*/
> -DEFPARAM (PARAM_SRA_MAX_STRUCTURE_SIZE,
> - ? ? ? ? "sra-max-structure-size",
> - ? ? ? ? "The maximum structure size (in bytes) for which GCC will "
> - ? ? ? ? "use by-element copies",
> - ? ? ? ? 0, 0, 0)
> -
> -/* The maximum number of structure fields which the SRA pass will
> - ? instantiate to avoid block copies. ?The default value, 0, implies
> - ? that GCC will select the appropriate value itself. ?*/
> -DEFPARAM (PARAM_SRA_MAX_STRUCTURE_COUNT,
> - ? ? ? ? "sra-max-structure-count",
> - ? ? ? ? "The maximum number of structure fields for which GCC will "
> - ? ? ? ? "use by-element copies",
> - ? ? ? ? 0, 0, 0)
> -
> -/* The ratio between instantiated fields and the complete structure
> - ? size. ?We say that if the ratio of the number of bytes in
> - ? instantiated fields to the number of bytes in the complete
> - ? structure exceeds this parameter, or if the number of instantiated
> - ? fields to the total number of fields exceeds this parameter, then
> - ? block copies are not used. ?The default is 75%. ?*/
> -DEFPARAM (PARAM_SRA_FIELD_STRUCTURE_RATIO,
> - ? ? ? ? "sra-field-structure-ratio",
> - ? ? ? ? "The threshold ratio between instantiated fields and the total structure size",
> - ? ? ? ? 75, 0, 100)
> -
> ?/* The threshold ratio between current and hottest structure counts.
> ? ?We say that if the ratio of the current structure count,
> ? ?calculated by profiling, to the hottest structure count
> Index: mine/gcc/params.h
> ===================================================================
> --- mine.orig/gcc/params.h
> +++ mine/gcc/params.h
> @@ -94,12 +94,6 @@ typedef enum compiler_param
> ? (compiler_params[(int) ENUM].set)
>
> ?/* Macros for the various parameters. ?*/
> -#define SRA_MAX_STRUCTURE_SIZE \
> - ?PARAM_VALUE (PARAM_SRA_MAX_STRUCTURE_SIZE)
> -#define SRA_MAX_STRUCTURE_COUNT \
> - ?PARAM_VALUE (PARAM_SRA_MAX_STRUCTURE_COUNT)
> -#define SRA_FIELD_STRUCTURE_RATIO \
> - ?PARAM_VALUE (PARAM_SRA_FIELD_STRUCTURE_RATIO)
> ?#define STRUCT_REORG_COLD_STRUCT_RATIO \
> ? PARAM_VALUE (PARAM_STRUCT_REORG_COLD_STRUCT_RATIO)
> ?#define MAX_INLINE_INSNS_SINGLE \
>
>