This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR37216 [cygming] Invalid alignment for SSE store to .comm data generated with -O3
- From: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- To: Dave Korn <dave dot korn dot cygwin at googlemail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Sun, 24 May 2009 03:57:29 +0100
- Subject: Re: [PATCH] Fix PR37216 [cygming] Invalid alignment for SSE store to .comm data generated with -O3
- References: <4A187898.1070202@gmail.com>
Dave Korn wrote:
> gcc/ChangeLog:
>
> PR target/37216
A tiny spot of self-review:
> Index: gcc/config/i386/winnt.c
> ===================================================================
> --- gcc/config/i386/winnt.c (revision 147710)
> +++ gcc/config/i386/winnt.c (working copy)
> @@ -510,9 +510,12 @@ i386_pe_asm_output_aligned_decl_common (FILE *stre
>
> fprintf (stream, "\t.comm\t");
> assemble_name (stream, name);
> - fprintf (stream, ", " HOST_WIDE_INT_PRINT_DEC "\t" ASM_COMMENT_START
There's a comment just above this point, that I should update along the
following lines before committing:
> - /* Compute as in assemble_noswitch_variable, since we don't actually
> - support aligned common. */
> + /* Compute as in assemble_noswitch_variable, since we don't have
> + support for aligned common on older binutils. */
(Don't think I'll re-run the entire testsuite for that change, though!)
cheers,
DaveK