Re: patch to solve PR39856

[Uros Bizjak <ubizjak at gmail dot com>]

Hello!

> Jakub Jelinek wrote:
>
>     On Fri, May 22, 2009 at 03:25:08PM -0400, Vladimir Makarov wrote:
>
>             ^^^ This isn't needed IMHO.
>
>                 +/* { dg-options "-O3 -fomit-frame-pointer -m32 -msse3
>                 -march=i586" } */
>
>         Why? The above option set will work on x86 and x86_64 without
>         a problem.
>
>
>     Because the decision whether to test with -m32 or -m64 should be
>     tester's
>     decision (how do you invoke make chec, e.g. with
>     make check RUNTESTFLAGS="--target_board=unix/\{-m32,-m64\}" you
>     want to test both, etc. Several people have been cleaning tests over
>     time not to have these...
>
> Jakub, thanks for the explanation. It looks like I have no skills to 
> write the tests.
>
> Taking you comments into account the new version of the patch looks like
>
> 2009-05-22 Vladimir Makarov <vmakarov@redhat.com>
>
> * testsuite/gcc.target/i386/pr39856.c: New test.
>
> Is it ok for the branch and trunk? I've checked it on x86 and x86_64.

+/* { dg-options "-O3 -fomit-frame-pointer -msse3" } */
+/* { dg-options "-O3 -fomit-frame-pointer -msse3 -march=i586" { target ilp32 } } */


Actually, please change these two lines to just:

/* { dg-options "-O3 -fomit-frame-pointer -msse3 -mfmpath=387" } */

The testcase will break for 32 bit _and_ 64 bit targets with unpatched gcc.


The patch is OK for mainline SVN and 4.4 branch with this change.

Thanks,
Uros.