This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] fix int vs enum issues with in stabs support


Olivier Hainque <hainque@adacore.com> writes:

> 2009-05-05  Olivier Hainque  <hainque@adacore.com>
>
> 	* gstab.h (stab_code_t): Define, to be used instead of the
> 	__stab_debug_code enum, made anonymous.
> 	* dbxout.c (STAB_CODE_TYPE): Remove #define and replace use
> 	occurrences by stab_code_t.
> 	* mips-tfile.c (STAB_CODE_TYPE): Remove #define, unused.


> Index: gstab.h

Please add 2009 to the list of copyright years.

> + /* stabs debug codes really are integers with convenient names.  */
> + typedef int stab_code_t;

Type names ending in "_t" are reserved by POSIX.1.  Use stab_code_type
instead.  Change all the uses.

This is OK with those changes.

Thanks.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]