This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |
Other format: | [Raw text] |
On Tue, May 19, 2009 at 1:02 PM, Andrew Pinski <pinskia@gmail.com> wrote: > On Tue, May 19, 2009 at 12:59 PM, H.J. Lu <hjl.tools@gmail.com> wrote: >> On Tue, May 19, 2009 at 11:58 AM, Andrew Pinski <pinskia@gmail.com> wrote: >>> On Mon, May 18, 2009 at 10:15 AM, H.J. Lu <hjl.tools@gmail.com> wrote: >>>> This is the patch I am checking in. >>>> >>>> Thanks. >>>> >>>> -- >>>> H.J. >>>> -- >>>> 2009-05-18 ?H.J. Lu ?<hongjiu.lu@intel.com> >>>> >>>> ? ? ? ?PR target/39942 >>>> ? ? ? ?* config/i386/i386.c (ix86_avoid_jump_misspredicts): Replace >>>> ? ? ? ?gen_align with gen_pad. >>>> ? ? ? ?(ix86_reorg): Check ASM_OUTPUT_MAX_SKIP_PAD instead of >>>> ? ? ? ?#ifdef ASM_OUTPUT_MAX_SKIP_ALIGN. >>>> >>>> ? ? ? ?* config/i386/i386.h (ASM_OUTPUT_MAX_SKIP_PAD): New. >>>> ? ? ? ?* config/i386/x86-64.h (ASM_OUTPUT_MAX_SKIP_PAD): Likewise. >>>> >>>> ? ? ? ?* config/i386/i386.md (align): Renamed to ... >>>> ? ? ? ?(pad): This. ?Replace ASM_OUTPUT_MAX_SKIP_ALIGN with >>>> ? ? ? ?ASM_OUTPUT_MAX_SKIP_PAD. >>>> >>> >>> This patch causes a bootstrap failure on i386-darwin because >>> ASM_OUTPUT_MAX_SKIP_ALIGN and ASM_OUTPUT_MAX_SKIP_PAD are defined at >>> different times. On darwin ASM_OUTPUT_MAX_SKIP_ALIGN is not defined >>> but ASM_OUTPUT_MAX_SKIP_PAD is defined. >>> >> >> Why is it a problem? I can't test it with a cross compiler. Please show >> the error message. >> > > /usr/libexec/gcc/i686-apple-darwin8/4.0.1/ld: Undefined symbols: > _ix86_avoid_jump_mispredicts > collect2: ld returned 1 exit status > > Thanks. I checked in this as an obvious fix. -- H.J. --- 2009-05-19 H.J. Lu <hongjiu.lu@intel.com> * config/i386/i386.c (ix86_avoid_jump_mispredicts): Check ASM_OUTPUT_MAX_SKIP_PAD instead of ASM_OUTPUT_MAX_SKIP_ALIGN.
Attachment:
foo.patch
Description: Text document
Index Nav: | [Date Index] [Subject Index] [Author Index] [Thread Index] | |
---|---|---|
Message Nav: | [Date Prev] [Date Next] | [Thread Prev] [Thread Next] |