This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Scalar evolution and hidden casts
On Tue, May 19, 2009 at 12:44 PM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> Beware! ?COMPLEX_EXPR is tcc_binary and your changes will
>> cause the wrong type to be used!
>
> You're right, but follow_ssa_edge_binary only handles POINTER_PLUS_EXPR,
> PLUS_EXPR and MINUS_EXPR so this doesn't really matter. ?I guess I should
> specifically test for the 3 codes, like in follow_ssa_edge_expr.
Yes, that would be better.
>> I suppose you specifically hit the POINTER_PLUS_EXPR case?
>> Maybe just special-case that like in gimple_expr_type and use
>> that in follow_ssa_edge_in_rhs.
>
> No, it's the PLUS_EXPR case.
Oh, ok.
I chickened out several times to reorganize the tree code binning
in tcc_binary/tcc_unary vs. tcc_expression ... maybe I should
come back to that.
Thanks,
Richard.
> --
> Eric Botcazou
>