Re: [C/C++/IRA] PR 16302 gcc fails to warn about some common logic errors

["H.J. Lu" <hjl dot tools at gmail dot com>]

On Sun, May 17, 2009 at 1:21 PM, Richard Guenther
<richard.guenther@gmail.com> wrote:
> On Sat, May 16, 2009 at 5:17 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
>> 2009/5/16 Manuel López-Ibáñez <lopezibanez@gmail.com>:
>>> That is strange, it should not warn for constants. Is it really 0 or
>>> something else?
>>
>>
>> I open a bug report with a testcase:
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=40172
>
> Given all this and that bootstrap is still not fixed for some targets
> I seriously
> doubt this warning is worth all this trouble.
>
> Thus, I suggest to revert the patch or make the warning not part of -Wall.
>

How about this patch?

-- 
H.J.
---
gcc/

2009-05-18  Manuel López-Ibáñez  <manu@gcc.gnu.org>

	PR c/40172
	* toplev.c (process_options): Avoid
	if (!FRAME_GROWS_DOWNWARD && flag_stack_protect).

gcc/testscase/

2009-05-18  H.J. Lu  <hongjiu.lu@intel.com>

	PR c/40172
	* gcc.dg/pr40172.c: Add more tests.

Attachment: gcc-pr40172-2.patch
Description: Text document