This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH RFA: -Wc++-compat warning about ++/-- with enum value
- From: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- To: Janne Blomqvist <blomqvist dot janne at gmail dot com>
- Cc: Ian Lance Taylor <iant at google dot com>, gcc-patches at gcc dot gnu dot org, fortran at gcc dot gnu dot org
- Date: Thu, 14 May 2009 13:27:55 -0700
- Subject: Re: PATCH RFA: -Wc++-compat warning about ++/-- with enum value
- References: <m3k54jn0ys.fsf@google.com> <4A0C7B61.8060803@gmail.com>
On Thu, May 14, 2009 at 11:13:21PM +0300, Janne Blomqvist wrote:
> Ian Lance Taylor wrote:
> >gcc/fortran/ChangeLog:
> >
> >2009-05-14 Ian Lance Taylor <iant@google.com>
> >
> > * decl.c (match_attr_spec): Change d to unsigned int.
> > * dump-parse-tree.c (show_namespace): Change op to int. Add cast.
> > * interface.c (gfc_check_interfaces): Change i to int. Add casts.
> > * module.c (read_module): Change i to int. Add cast.
> > (write_module): Change i to int.
> > * symbol.c (gfc_get_namespace): Change in to int.
> > (gfc_free_namespace): Change i to int.
> > * trans-io.c (gfc_build_io_library_fndecls): Change ptype to
> > unsigned int. Add cast.
> > * trans-types.c (gfc_init_kinds): Change mode to unsigned int.
> > Add casts.
>
> Fortran parts are Ok. However, since Steve evidently disagrees, I guess
> we need the opinion of a third Fortran maintainer to break the stalemate.
>
I don't disagree with the change. I'm simply concerned that the
new requirements of C++ knowledge (even a minimal knowledge) is
going to raise the bar too high to attract additional gfortran
contributors. Janus is the last fresh blood and he joined our
merry brood 2+ years ago.
--
Steve