This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch, Fortran] PR 39996: Double typing of function results not detected
- From: Janus Weil <janus at gcc dot gnu dot org>
- To: Steve Kargl <sgk at troutmask dot apl dot washington dot edu>
- Cc: gfortran <fortran at gcc dot gnu dot org>, gcc patches <gcc-patches at gcc dot gnu dot org>, Paul Thomas <paul dot richard dot thomas at gmail dot com>, Daniel Kraft <d at domob dot eu>
- Date: Wed, 13 May 2009 10:02:34 +0200
- Subject: Re: [Patch, Fortran] PR 39996: Double typing of function results not detected
- References: <854832d40905090954m4b15450fj4e5c4aaff4c1cbd1@mail.gmail.com> <20090512222201.GB97315@troutmask.apl.washington.edu>
>> In my opinion it is hard enough to build a compiler which is able to
>> check pedantically if a given program is valid with respect to F95,
>> F2003 and/or F2008. So there is need for us to invent yet another
>
> s/is need/is no need/
>
> I agree!
It's nice when people understand you, even though you talk garbage ;)
>> 2009-05-09 ?Janus Weil ?<janus@gcc.gnu.org>
>>
>> ? ? ? PR fortran/39996
>> ? ? ? * decl.c (gfc_match_function_decl): Use gfc_add_type.
>> ? ? ? * symbol.c (gfc_add_type): Better checking for duplicate types in
>> ? ? ? function declarations. And: Always give an error for duplicte types,
>> ? ? ? not just a warning with -std=gnu.
>>
>>
>> 2009-05-09 ?Janus Weil ?<janus@gcc.gnu.org>
>>
>> ? ? ? PR fortran/39996
>> ? ? ? * gfortran.dg/func_decl_2.f90: Modified (replacing warnings by errors).
>> ? ? ? * gfortran.dg/duplicate_type_2.f90: Ditto.
>> ? ? ? * gfortran.dg/duplicate_type_3.f90: New.
>
> OK.
Thanks for the approval, Steve. Actually I would feel better if the
authors of the PRs 16943 and 30239, i.e. Paul and Daniel K., also OKed
this patch (or at least take note of it). Therefore I will not commit
before tomorrow.
Cheers,
Janus