Re: [PATCH] Fix bootstrap fail on spu vs. ira.c/genpreds

[Michael Meissner <meissner at linux dot vnet dot ibm dot com>]

On Mon, Apr 27, 2009 at 03:52:11PM +0100, Dave Korn wrote:
> 
>     Hello all,
> 
> 
>   As discussed on the main list earlier today[*], there is currently an
> implicit assumption in ira.c that every backend implements at least one
> define_register_constraint; when the backend doesn't, genpreds does not output
> any definition for regclass_for_constraint and then ira.c (which refers to it
> unguarded) fails to link.
> 
> 
> gcc/ChangeLog
> 
> 	* ira.c (setup_cover_and_important_classes):  Use safe macro
> 	REG_CLASS_FOR_CONSTRAINT instead of calling regclass_for_constraint
> 	directly.
> 	* genpreds.c (write_tm_preds_h):  Output suitable definition of
> 	REG_CLASS_FOR_CONSTRAINT.
> 
>   The attached patch fixes the reported bug according to Revital; I'm putting
> it through a bootstrap right now (all languages except for Ada), on
> i686-pc-cygwin, which is a platform that won't hit the new code paths, so can
> I skip running the testsuites?  Ok for trunk?
> 
>     cheers,
>       DaveK
> -- 
> [*] - http://gcc.gnu.org/ml/gcc/2009-04/threads.html#00696

I applied this patch to the mainline.  Thanks for doing this.

Vlad, if you would prefer to submit a new patch to eliminate the
REG_CLASS_FOR_CONSTRAINT macro as you discussed in the replies, I would have no
problems with that either.

-- 
Michael Meissner, IBM
4 Technology Place Drive, MS 2203A, Westford, MA, 01886, USA
meissner@linux.vnet.ibm.com