This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: plugins & PCH are incompatible ...
On Tue, 28 Apr 2009, Manuel López-Ibáñez wrote:
> 2009/4/28 Joseph S. Myers <joseph@codesourcery.com>:
> > On Tue, 28 Apr 2009, Basile STARYNKEVITCH wrote:
> >
> >> This suggests to test the plugins in c-pch.c. Hence the attached patch
> >> (bootstrapped on x86_64-linux-gnu with C enabled).
> >>
> >> gcc/ChangeLog:
> >>
> >> 2009-04-28 ?Basile Starynkevitch ?<basile@starynkevitch.net>
> >>
> >> ? ? ? ?* c-pch.c: Added include "plugin.h".
> >> ? ?(pch_init) Issue an error when generating a PCH file with plugins.
> >>
> >> Ok for trunk?
> >
> > OK if you fix the error message to follow the GNU Coding Standards for
> > error messages (do not start with a capital error, do not end with a
> > period).
>
> Shouldn't this need a testcase?
I believe the plugins testsuite infrastructure is still pending review,
but once that's in then yes this could do with a testcase.
--
Joseph S. Myers
joseph@codesourcery.com