This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [RFA] expand from SSA form (1/2)
On Thu, Apr 23, 2009 at 4:30 PM, Andrew MacLeod <amacleod@redhat.com> wrote:
> Michael Matz wrote:
>>
>> On Wed, 22 Apr 2009, Michael Matz wrote:
>>
>> I'd like to ask for approval for the series.
>>
>>
>> Ciao,
>> Michael.
>>
>
> Looks good to me.
>
> Andrew
>
>
>
>
>
>> --- 233,251 ----
> ? ? ? ? ? ?if (gimple_assign_copy_p (stmt)
> ? ? ? ? ? ? ? ?&& gimple_assign_lhs (stmt) == result
> ? ? ? ? ? ? ? ?&& gimple_assign_rhs1 (stmt) == found)
>> ! ? ? ? ? {
>> ! ? ? ? ? ? unlink_stmt_vdef (stmt);
>> ! ? ? ? ? ? gsi_remove (&gsi, true);
>> ! ? ? ? ? }
> ? ? ? ? ? ?else
>
> Unrelated to your patch, but out of curiosity, shouldn't gsi_remove()
> automatically do an unlink_stmt_vdef() if the remove_permanently flag is
> true like it is here? ?Seems like an oversight bug waiting to happen...
No, similar to release_defs unlink_stmt_vdef should not be done
if you plan to re-use the virtual operands of the stmt, for example
when replacing the stmt with a newly built one.
Richard.