This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Add multilib config for powerpc-xilinx-eabi


David Edelsohn wrote:
On Wed, Apr 22, 2009 at 8:35 PM, Michael Eager <eager@eagercon.com> wrote:
Add multilib configuration for powerpc-xilinx-eabi.
Tested with --target=powerpc-eabisim.


2009-04-22 Michael Eager <eager@eagercon.com>


       * config/rs6000/t-xilinx: New, multilib for Xilinx PPC with
       single/double precision FPU.
       * config.gcc: Replace t-ppcgas & t-ppccomm with t-xilinx for
       powerpc-xilinx-eabi.

Michael,


I am concerned about the direction this patch is taking Xilinx
support.  The patch probably is correct, but this patch is duplicating
a lot of t-ppcgas and t-ppccomm instead of factoring out the changes
for t-xilinx.  The problem is future maintenance.  If someone needs to
fix something in t-ppcgas or t-ppccomm in the future, they may not
notice to check t-xilinx and change t-xilinx as well.  t-xilinx also
loses on the common testing.

Ok, I'll look at making t-xilinx just override or augument t-ppcgas & t-ppccomm.


-- Michael Eager eager@eagercon.com 1960 Park Blvd., Palo Alto, CA 94306 650-325-8077


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]