This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: EH verifier and dumping II
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Jan Hubicka <hubicka at ucw dot cz>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Thu, 23 Apr 2009 06:41:31 -0700
- Subject: Re: EH verifier and dumping II
- References: <20090409081057.GA23648@kam.mff.cuni.cz>
On Thu, Apr 9, 2009 at 1:10 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> writing verifier hardly goes without finding some latent bug. ?This is
> what I ended up comitting. ?There is bug in computing prev_try pointer
> in duplicate_eh_regions when duplicating just part of tree for GOMP.
> This shows in two GOMP testcases.
>
> I think the REMAP can handle the pointer without this patch arbitrarily
> wrongly resulting in ICE or wrong CFG or both.
>
> Honza
>
> Bootstrapped/regtested x86_64-linux, comitted.
>
> ? ? ? ?* except.c (find_prev_try): Break out from ....
> ? ? ? ?(duplicate_eh_regions): ... here; properly update prev_try pointers
> ? ? ? ?when duplication part of tree.
> ? ? ? ?(dump_eh_tree): Improve dumping.
> ? ? ? ?(verify_eh_region): New.
> ? ? ? ?(verify_eh_tree): Use it.
This may have caused:
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39862
--
H.J.