This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: newlib stdint INTPTR_MAX etc fixincludes patch
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: bkorb at gnu dot org
- Cc: hans-peter dot nilsson at axis dot com, joseph at codesourcery dot com, gcc-patches at gcc dot gnu dot org
- Date: Sun, 19 Apr 2009 01:38:38 +0200
- Subject: Re: newlib stdint INTPTR_MAX etc fixincludes patch
> Date: Thu, 16 Apr 2009 16:40:58 -0700
> From: Bruce Korb <bkorb@gnu.org>
> Hans-Peter Nilsson wrote:
> >> or a corresponding
> >> fixincludes patch is applied;
> >
> > Not exactly the same: by brief inspection of results and log,
> > apparently fixincludes isn't run when newlib is compiled in a
> > "combined tree" (with newlib a sibling subdir of gcc) so it
> > doesn't help at least in my usual setup.
>
> I'm a little confused about the meaning of this.
It effectively means the fixincludes patch has no effect,
because fixincludes isn't run in the arguably "most common"
installation scenario for newlib, which IMHO makes the patch
less desirable.
> Anyway, what you've done looks pretty reasonable from
> my perspective. Cheers - Bruce
Thanks.
brgds, H-P