This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove arm-*-* from target of test _Pragma1.C and _Pragma6.c?


> I see that you've filed
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=39781 for this. Please
> refer the necessary PR in your ChangeLog entry as PR target/39781.
>
> I can't approve the patch but I have a couple of comments about the
> patch. I've CC'd one of the maintainers of the ARM backend for his
> approval.
>
> Please put a copy of the ChangeLog entry in your email and not make
> the ChangeLog a part of your patch.
>
>
> +
> +/* Define this so we can compile MS code for use with WINE.  */
>
> I'd reword this to remove references to WINE or MS.
>
> Something of the form - "Define this for compatibility reasons." might
> be better.
>
>
> Thanks -
> Ramana
>

2009-04-17  Jing Yu  <jingyu@google.com>

        PR testsuite/39781
        * config/arm/arm.h: Define HANDLE_PRAGMA_PACK_PUSH_POP.


Did the change.

Thanks very much!

Jing
Index: config/arm/arm.h
===================================================================
--- config/arm/arm.h	(revision 146221)
+++ config/arm/arm.h	(working copy)
@@ -2247,7 +2247,9 @@ do {							\
 #define GO_IF_MODE_DEPENDENT_ADDRESS(ADDR, LABEL)	\
   if (TARGET_32BIT)					\
     ARM_GO_IF_MODE_DEPENDENT_ADDRESS (ADDR, LABEL)
-
+
+/* Define this for compatibility reasons. */
+#define HANDLE_PRAGMA_PACK_PUSH_POP
 
 /* Specify the machine mode that this machine uses
    for the index in the tablejump instruction.  */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]