This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Remove arm-*-* from target of test _Pragma1.C and _Pragma6.c?


On Thu, Apr 16, 2009 at 2:47 PM, Ramana Radhakrishnan
<ramana.r@gmail.com> wrote:
> Just defining it should work fine. I don't know of any reason why this
> shouldn't be supported. Thanks for offering to put it in and test it

I defined HANDLE_PRAGMA_PACK_PUSH_POP in arm.h and did dejagnu gcc and
g++ test again.

Configured with: /home/jingyu/projects/gcc/gcc_trunk/configure
--prefix=/home/jingyu/projects/gcc/obj-arm_eabi2/install
--target=arm-eabi --build=i686-linux --host=i686-linux
--with-gmp=/home/jingyu/projects/gcc/obj-arm_eabi2/install
--with-mpfr=/home/jingyu/projects/gcc/obj-arm_eabi2/install
--enable-multilib --with-newlib --with-gnu-as --with-gnu-ld
--enable-languages=c,c++
Thread model: single
gcc version 4.5.0 20090417 (experimental) (GCC)

The only difference is that
g++.dg/cpp/_Pragma1.C and gcc.dg/cpp/_Pragma6.c become 'pass'.

The attachment is the patch to add the definition.

      * config/arm/arm.h: Define HANDLE_PRAGMA_PACK_PUSH_POP.

Is it ok for trunk and GCC-4.4 branch?

I did both dejaGNU test for trunk and gcc-4.4 branch.

Thanks,
Jing
Index: ChangeLog
===================================================================
--- ChangeLog	(revision 146221)
+++ ChangeLog	(working copy)
@@ -1,3 +1,7 @@
+2009-04-17  Jing Yu  <jingyu@google.com>
+
+	* config/arm/arm.h: Define HANDLE_PRAGMA_PACK_PUSH_POP.
+
 2009-04-16  Joseph Myers  <joseph@codesourcery.com>
 
 	* config/mips/mips.c (mips_rtx_cost_data): Use SOFT_FP_COSTS in
Index: config/arm/arm.h
===================================================================
--- config/arm/arm.h	(revision 146221)
+++ config/arm/arm.h	(working copy)
@@ -2247,7 +2247,9 @@ do {							\
 #define GO_IF_MODE_DEPENDENT_ADDRESS(ADDR, LABEL)	\
   if (TARGET_32BIT)					\
     ARM_GO_IF_MODE_DEPENDENT_ADDRESS (ADDR, LABEL)
-
+
+/* Define this so we can compile MS code for use with WINE.  */
+#define HANDLE_PRAGMA_PACK_PUSH_POP
 
 /* Specify the machine mode that this machine uses
    for the index in the tablejump instruction.  */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]