This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [cond-optab] final tweaks part 1
- From: Hans-Peter Nilsson <hans-peter dot nilsson at axis dot com>
- To: bonzini at gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Sun, 12 Apr 2009 05:46:55 +0200
- Subject: Re: [cond-optab] final tweaks part 1
> From: Paolo Bonzini <bonzini@gnu.org>
> Date: Fri, 10 Apr 2009 16:36:46 +0200
> here are the
> fixes exposed by the test run on the other targets.
I assume targets not mentioned were fine after these changes?
> * config/mmix/mmix.md (movdfcc): Do not handle LE and GE.
Ok.
> * config/cris/cris.c (cris_normal_notice_update_cc): Handle btstq
> on one bit.
Not strongly, but I'd write "Reinstate code to handle..."
> Index: gcc/config/cris/cris.c
> ===================================================================
> --- gcc/config/cris/cris.c (branch cond-optab)
> +++ gcc/config/cris/cris.c (working copy)
> @@ -1438,7 +1438,9 @@ cris_normal_notice_update_cc (rtx exp, r
> else
> cc_status.value1 = SET_SRC (exp);
>
> - if (GET_CODE (cc_status.value1) == ZERO_EXTRACT)
> + /* Handle flags for the special btstq on one bit. */
> + if (GET_CODE (cc_status.value1) == ZERO_EXTRACT
> + && XEXP (cc_status.value1, 1) == const1_rtx)
> {
...as this is code that was just apparently accidentally deleted
when you adjusted for the tstM removal! (I had to look closer
as I wondered how I'd missed handling that 1-bit btstq and
wondered why code matching the patch was on trunk. :)
brgds, H-P