This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PATCH: Initialize ix86_abi in override_options
- From: Kai Tietz <ktietz70 at googlemail dot com>
- To: "H.J. Lu" <hjl dot tools at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>, Uros Bizjak <ubizjak at gmail dot com>
- Date: Wed, 1 Apr 2009 20:45:27 +0200
- Subject: Re: PATCH: Initialize ix86_abi in override_options
- References: <6dc9ffc80904011141i75a3ea8bxbe3cc6baf5bbd790@mail.gmail.com>
2009/4/1 H.J. Lu <hjl.tools@gmail.com>:
> On Wed, Apr 1, 2009 at 11:16 AM, Kai Tietz <ktietz70@googlemail.com> wrote:
>> Hello H.J,
>>
>> the definition of enum calling_abi ix86_abi = DEFAULT_ABI; breaks
>> build for mingw-w64 at the moment.
>> We get ../../gcc/gcc/config/i386/i386.c:1747: error: initializer
>> element is not constant.
>>
>> So I assume the initialization has to be done in function.
>>
>> Cheers,
>> Kai
>>
>
> DEFAULT_ABI may not be a constant. ?This patch fixes it.
> OK for trunk?
>
> Thanks.
>
>
> --
> H.J.
> ---
> 2009-04-01 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?* config/i386/i386.c (ix86_abi): Move initialization to ...
> ? ? ? ?(override_options): Here.
>
For me ok. Let Uros do the final approval.
Thanks,
Kai
--
| (\_/) This is Bunny. Copy and paste
| (='.'=) Bunny into your signature to help
| (")_(") him gain world domination