This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Allow symbol versioning to be disabled for libgfortran and libssp


Hello,

* FX wrote on Sat, Mar 28, 2009 at 12:20:46PM CET:
> [I write this long due reply with Tobias Burnus' accord, since I'm no  
> longer a maintainer myself.]
>
> http://gcc.gnu.org/ml/gcc-patches/2009-01/msg01170.html
>> 	libgfortran/
>> 	* configure.ac: Add --enable-symvers.
>> 	* configure: Regenerate.
>
> The patch itself seems OK. I'd be more comfortable if a build maintainer 
> could review it, but if you don't hear back from them, please go ahead. 
> (You still need approval for libssp changes, though.)

I'm not a build maintainer, nor have I reviewed the patch in detail, but

+if test "x$enable_symvers" == "xno"; then

is a bashism, replace the "==" with "=" (several instances).

Cheers,
Ralf


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]