This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: pretty-ipa merge 2: master clones removal


On Sat, Mar 28, 2009 at 12:01 PM, Jan Hubicka <hubicka@ucw.cz> wrote:
> Hi,
> this patch removes master clones that are not really used anywhere
> anymore and are not compatible with the new clonning infrastructure.
>
> Bootstrapped/regtested x86_64-linux, comitted.
>
> Index: ChangeLog
> ===================================================================
> *** ChangeLog ? (revision 145174)
> --- ChangeLog ? (working copy)
> ***************
> *** 1,5 ****
> --- 1,15 ----
> ?2009-03-28 ?Jan Hubicka ?<jh@suse.cz>
>
> + ? ? ? * cgraph.c (cgraph_node, cgraph_remove_node, dump_cgraph_node,
> + ? ? ? cgraph_clone_node): Remove master clone handling.
> + ? ? ? (cgraph_is_master_clone, cgraph_master_clone): Remove.
> + ? ? ? * cgraph.h (master_clone): Remove.
> + ? ? ? (cgraph_is_master_clone, cgraph_master_clone): Remove.
> + ? ? ? * ipa-type-escape.c (type_escape_execute): Remove use of master clone.
> + ? ? ? ( tree-ssa-structalias.c (ipa_pta_execute): LIkewise.

Typo.  Also the tree-ssa-structalias.c change broke gcc.dg/torture/ipa-pta-1.c,
I think the following will fix it, but I wonder what to do about
clones - just process
them?

--- trunk/gcc/tree-ssa-structalias.c	2009/03/28 10:48:04	145174
+++ trunk/gcc/tree-ssa-structalias.c	2009/03/28 11:00:07	145175
@@ -5669,7 +5669,7 @@

   for (node = cgraph_nodes; node; node = node->next)
     {
-      if (!node->analyzed || cgraph_is_master_clone (node))
+      if (!node->analyzed)
 	{
 	  unsigned int varid;

also remove the !node->analyzed check and process all nodes.

Richard.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]