This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Build a tri-arch compiler on mips-linux-gnu


Arthur Loiret <aloiret@debian.org> writes:
> This patch is an improved version of the one we're using in Debian.
> It saves the current behaviour on mips-linux-gnu and mips64-linux-gnu,
> and builds a tri-arch (o32/n32/64) compiler defaulted to o32 on
> mips-linux-gnu is --enable-targets=all is set. Regtesting running on
> mips-linux-gnu (o32 userspace and 64-bit kernel), and I plan go do one
> on mips64-linux-gnu too.
> Ok for trunk when stage1 opens if all pass?

Looks good, thanks.  My only (very) minor nit is that...

>  /* Force the default endianness and ABI flags onto the command line
> -   in order to make the other specs easier to write.  */
> +   in order to make the other specs easier to write.
> +   On mips64, config.gcc defines MIPS_ABI_DEFAULT to ABI_N32, so
> +   we can use MULTILIB_ABI_DEFAULT.  */

...I don't think this comment is really necessary.  MULTILIB_ABI_DEFAULT
is meant to be a general mechanism for any multilibbed target, so we don't
need to explain away its use.  I'm just worried that specific cross-references
like this can easily get out of date.

OK for 4.5 with that change.  Do you have a copyright assignment on file?

Richard


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]