This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] DO_GLOBAL_CTORS_BODY needs uintptr_t


Ozkan Sezer <sezeroz@gmail.com> writes:

> 2009-03-17  Ozkan Sezer <sezeroz@gmail.com>
>
> 	* gbl-ctors.h (DO_GLOBAL_CTORS_BODY): Cast to __SIZE_TYPE__ instead of
> 	unsigned long to avoid the win64 warning. (uintptr_t would be a better
> 	choice if it were reliably defined on all targets...)

ChangeLog entries should just say what was changed, not why.  You can
add the parenthetical comment to the source code if you like.  The
ChangeLog entry should simply be "Cast to __SIZE_TYPE__ instead of
unsigned long."

How did you test this patch?

This is OK if it bootstraps on a primary platform.

Ian


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]