This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: PATCH: PR c++/36411: [4.4 regression] ICE with invalid template template parameter

From: Jason Merrill <jason at redhat dot com>
To: "H.J. Lu" <hjl dot tools at gmail dot com>
Cc: gcc-patches at gcc dot gnu dot org
Date: Mon, 23 Feb 2009 17:19:12 -0500
Subject: Re: PATCH: PR c++/36411: [4.4 regression] ICE with invalid template template parameter
References: <20090223172242.GA14403@lucon.org> <49A31379.4060903@redhat.com> <6dc9ffc80902231403n7aa3685ex187a7c67c647d36f@mail.gmail.com>

H.J. Lu wrote:

The current code is

 if (TREE_VEC_ELT (parm_parms, nparms - 1) != error_mark_node)
    {
      parm = TREE_VALUE (TREE_VEC_ELT (parm_parms, nparms - 1));

Did I miss something?

No, clearly I did. Go ahead and apply your patch; I prefer checking for error_mark_node over adding an ERROR_MARK case.

Jason

References:
- PATCH: PR c++/36411: [4.4 regression] ICE with invalid template template parameter
  - From: H.J. Lu
- Re: PATCH: PR c++/36411: [4.4 regression] ICE with invalid template template parameter
  - From: Jason Merrill
- Re: PATCH: PR c++/36411: [4.4 regression] ICE with invalid template template parameter
  - From: H.J. Lu

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]