Re: [patch] Fix -ftree-loop-distribution (PR tree-optimization/39007)

[Kazu Hirata <kazu at codesourcery dot com>]

Hi Sebastian,

> > The patch fixes the problem with:
> >
> >  set_immediate_dominator (CDI_DOMINATORS, dest,
> >                           recompute_dominator (CDI_DOMINATORS, dest));
> >
> > Basic blocks for the loop are removed, so DEST should be the only
> > basic block we need to update the immediate dominator of.
>
> The patch looks good, but I cannot approve.

Thanks.  More eyes, especially yours, should definitely help.

> > 2009-01-29  Kazu Hirata  <kazu@codesourcery.com>
> >
> >        PR tree-optimization/39007
> >        * tree-loop-distribution.c (generate_memset_zero): Use
> >        POINTER_PLUS_EXPR for a pointer addition.
>
> This changelog entry should be something different...

Oops.  I meant to say something like:

2009-01-29  Kazu Hirata  <kazu@codesourcery.com>

        PR tree-optimization/39007
        * tree-loop-distribution.c (generate_builtin): Use
        recompute_dominator to compute the immediate dominator of the
        basic block just after the loop.

Kazu Hirata