This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [lto][patch] Use @args when calling xgcc from lto-wrapper


On Thu, Jan 29, 2009 at 11:12, Rafael Espindola <espindola@google.com> wrote:
> Since lto-wrapper might have a long command line, it has to use @args
> when passing the arguments to xgcc.
>
> I also pigbacked a small cleanup t ocollect_execute.
>
> 2009-01-29  Rafael Avila de Espindola  <espindola@google.com>
>
>        * lto-wrapper.c (collect_execute): Remove unused vars.
>        (fork_execute): Write argv to a file and pass that to the command.

OK with

> +  char *args_name = make_temp_file(".args");
> +  char *at_args = concat("@", args_name, NULL);

Space before '('.

> +  for (i = 1; argv[i]; i++)
> +    fprintf(args, "%s\n", argv[i]);

Space before '('.


Diego.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]