This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Warn about bogus conditional operators

2009/1/17 Andi Kleen <andi@firstfloor.org>:
>> I'll propose something along the lines of:
>>
>> > +      warning (OPT_Wparentheses,
>> > +              "the omitted middle operand in ?: will always be %<true%>, suggest explicit middle operand");
>
> Makes sense.
>
>>
>> I also think that having a new option for this warning is too much.
>> This can be included in Wparentheses or another option.
>
> Ok i can put it into Wparenthesis
>
> Thanks for the review.
>

I should have pointed out that I am not an official reviewer. I can't
accept/reject your patch. An actual reviewer may actually disagree
with me.

Cheers,

Manuel.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]