This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] correct parameter alignment for library calls in calls.c
- From: Ian Lance Taylor <iant at google dot com>
- To: Hariharan <hariharans at picochip dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Mon, 12 Jan 2009 10:36:30 -0800
- Subject: Re: [PATCH] correct parameter alignment for library calls in calls.c
- References: <47B5C906.6090408@picochip.com> <47BD69EE.1050007@picochip.com>
Hariharan <hariharans@picochip.com> writes:
>> Index: gcc/calls.c
>> ===================================================================
>> --- gcc/calls.c (revision 132323)
>> +++ gcc/calls.c (working copy)
>> @@ -3660,6 +3660,7 @@
>> rtx val = argvec[argnum].value;
>> rtx reg = argvec[argnum].reg;
>> int partial = argvec[argnum].partial;
>> + unsigned int parm_align = argvec[argnum].locate.boundary;
>> int lower_bound = 0, upper_bound = 0, i;
>>
>> if (! (reg != 0 && partial == 0))
>> @@ -3721,7 +3722,7 @@
>> }
>> }
>>
>> - emit_push_insn (val, mode, NULL_TREE, NULL_RTX, PARM_BOUNDARY,
>> + emit_push_insn (val, mode, NULL_TREE, NULL_RTX, parm_align,
>> partial, reg, 0, argblock,
>> GEN_INT (argvec[argnum].locate.offset.constant),
>> reg_parm_stack_space,
>>
>>
This patch is OK for gcc 4.5 with a ChangeLog entry. (Mainline is
currently only open for patches which fix regressions, and I would
prefer that this patch get wider testing before a release.)
Thanks. Sorry for the slow review.
Ian